Skip to content

[alert] Migrate AlertTitle to emotion#24448

Merged
mnajdova merged 3 commits into
mui:nextfrom
povilass:migrate/component-alert-title
Jan 19, 2021
Merged

[alert] Migrate AlertTitle to emotion#24448
mnajdova merged 3 commits into
mui:nextfrom
povilass:migrate/component-alert-title

Conversation

@povilass

@povilass povilass commented Jan 16, 2021 •
edited by oliviertassinari
Loading

Copy link
Copy Markdown
Contributor

One iteration of #24405

@mui-pr-bot

mui-pr-bot commented Jan 16, 2021 •
edited
Loading

Copy link
Copy Markdown

@material-ui/core: parsed: +0.08% , gzip: +0.08%

Details of bundle changes

Generated by 🚫 dangerJS against 2259beb

@oliviertassinari oliviertassinari added the scope: alert Changes related to the alert. label Jan 16, 2021
mnajdova
mnajdova reviewed Jan 16, 2021
View reviewed changes
Comment thread packages/material-ui/src/AlertTitle/AlertTitle.test.js Outdated
@povilass

povilass commented Jan 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

For now, I disabled the test but when @mnajdova will finish a task with which provides skipping some test, this component finished. Don't want to mix test issue with migration at this point.

@oliviertassinari oliviertassinari changed the title [AlertTitle] Migrate to emotion [Alert] Migrate AlertTitle to emotion Jan 17, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 17, 2021
Closed
@mnajdova mnajdova changed the title [Alert] Migrate AlertTitle to emotion [AlertTitle] Migrate to emotion Jan 18, 2021
@mnajdova mnajdova mentioned this pull request Jan 18, 2021
Merged
@mnajdova

mnajdova commented Jan 18, 2021

Copy link
Copy Markdown
Member

For now, I disabled the test but when @mnajdova will finish a task with which provides skipping some test, this component finished. Don't want to mix test issue with migration at this point.

#24479 has been merged. Feel free to rebase and disable only the themeVariants test suite

@povilass

povilass commented Jan 18, 2021

Copy link
Copy Markdown
Contributor Author

Ok gonna do that later.

@mnajdova

mnajdova commented Jan 18, 2021

Copy link
Copy Markdown
Member

@povilass there are too many unrelated changes on the PR. Could you try to rebase again to latest next?

@oliviertassinari oliviertassinari changed the title [AlertTitle] Migrate to emotion [Alert] Migrate AlertTitle to emotion Jan 18, 2021
@povilass

povilass commented Jan 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Jesus smashing my head now because I am trying to rebase the wrong branch... xd @mnajdova

mnajdova
mnajdova reviewed Jan 18, 2021
View reviewed changes
Comment thread packages/material-ui/src/AlertTitle/AlertTitle.js Outdated
mnajdova
mnajdova approved these changes Jan 18, 2021
View reviewed changes

@mnajdova mnajdova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, looks good otherwise 👍 Thanks!

@povilass

povilass commented Jan 18, 2021

Copy link
Copy Markdown
Contributor Author

Nit done :)

@mnajdova
mnajdova merged commit 2977a30 into mui:next Jan 19, 2021
@oliviertassinari oliviertassinari changed the title [Alert] Migrate AlertTitle to emotion [alert] Migrate AlertTitle to emotion May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments
@mnajdova mnajdova mnajdova approved these changes

Assignees

No one assigned

Labels

scope: alert Changes related to the alert.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@povilass @mui-pr-bot @mnajdova @oliviertassinari