[Grid] Migrate to emotion#24395
Conversation
mnajdova
commented
Jan 13, 2021
mnajdova
commented
- I have followed (at least) the PR section of the contributing guide.
|
@material-ui/core: parsed: +0.33% , gzip: +0.34% |
| let className = ((member as babel.types.TSPropertySignature) | ||
| .key as babel.types.Identifier).name; | ||
|
|
||
| if(!className) { |
There was a problem hiding this comment.
We need this change in order to support classess that are in kebab-case like grid-xs-auto for example
…-width screen size agnostic grid tests
| ) => { | ||
| const propFullNameSafe = propFullName || propName; | ||
|
|
||
| // eslint-disable-next-line react/forbid-foreign-prop-types |
There was a problem hiding this comment.
I've got this failing test now https://app.circleci.com/pipelines/github/mui-org/material-ui/35659/workflows/8454c729-bc8f-49ba-8ae5-9fde972ca739/jobs/215603
Also, not sure how smart it is to disable this rule - https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-foreign-prop-types.md
I will revert the changes related to this and open a separte PR on this tomorrow.
There was a problem hiding this comment.
Also, not sure how smart it is to disable this rule - https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-foreign-prop-types.md
The eslint rule docs links https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types to the why. It's fine in our case. The block is wrapped with the process.env.NODE_ENV === 'production' condition.
There was a problem hiding this comment.
Alright, anyway will fix it separately to keep this PR clean
4 participants
