[Select] Improve description on how it extends the Input components#24180
Merged
Conversation
oliviertassinari
changed the title
oliviertassinari
added
scope: select
Add in some information on how to resize the select component. I couldn't find this information and was going to start adding in custom styles until I foud the size prop, so I hope this can also help others.
oliviertassinari
force-pushed
the
patch-1
branch
from
December 30, 2020 12:46
aff3e2d to
36998fd
Compare
oliviertassinari
approved these changes
Dec 30, 2020
mbrookes
reviewed
Dec 30, 2020
Member
|
Aside: Should this component be updated to be outlined by default, like the TextField? |
Co-authored-by: Matt <[email protected]>
Member
@mbrookes Well spotted, yes, it would make more sense. |
mbrookes
reviewed
Dec 31, 2020
Co-authored-by: Matt <[email protected]>
Member
|
@mbrookes Feel free to continue with a follow-up polish PR |
Contributor
|
@mbrookes @oliviertassinari I will give the default outlined select a try. |
Member
|
@petyosi Sounds great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add in some information on how to resize the select component. I couldn't find this information and was going to start adding in custom styles until I foud the size prop, so I hope this can also help others.