Skip to content

[docs] Add infrastructure to translate API pages#23726

Closed
oliviertassinari wants to merge 36 commits into
mui:nextfrom
oliviertassinari:docs-react-api
Closed

[docs] Add infrastructure to translate API pages#23726
oliviertassinari wants to merge 36 commits into
mui:nextfrom
oliviertassinari:docs-react-api

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Nov 25, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

A continuation of #23214 (comment).

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation. label Nov 25, 2020
@mui-pr-bot

mui-pr-bot commented Nov 25, 2020 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against 51816d2

@oliviertassinari
oliviertassinari force-pushed the docs-react-api branch 3 times, most recently from 4a1e58d to b2dcc8c Compare November 25, 2020 23:22
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 25, 2020
@github-actions github-actions Bot mentioned this pull request Nov 25, 2020
Closed
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 25, 2020
@oliviertassinari
oliviertassinari marked this pull request as ready for review November 25, 2020 23:26
oliviertassinari
oliviertassinari commented Nov 25, 2020
View reviewed changes
Comment thread docs/src/pages.ts Outdated
@oliviertassinari oliviertassinari changed the title [docs] Create React page to host json API pages [docs] Create React component to host json API pages Nov 25, 2020
@oliviertassinari
oliviertassinari requested review from eps1lon and mbrookes and removed request for mbrookes November 25, 2020 23:51
eps1lon
eps1lon requested changes Nov 26, 2020
View reviewed changes

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about the terminology used for the new components. This looks like it's trying too hard to DRY it out:

  1. TopLayoutApi
  2. TopLayoutDocs
  3. AppLayoutDocs

The linked preview no longer has the feedback UI.

I don't really understand this PR. If it isn't useful on its own then we should extract it. Otherwise we have this piece of code checked-in without purpose.

Comment thread docs/src/pages.ts Outdated
@oliviertassinari

This comment has been minimized.

Sign in to view
@eps1lon

This comment has been minimized.

Sign in to view
@eps1lon

This comment has been minimized.

Sign in to view
@mbrookes

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@mbrookes

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 26, 2020
@eps1lon

This comment has been minimized.

Sign in to view
@mbrookes

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@mbrookes

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Dec 3, 2020
@oliviertassinari

oliviertassinari commented Dec 5, 2020

Copy link
Copy Markdown
Member Author

@mbrookes I believe it's good to merge now. I would recommend you re-open this pull request with your name, otherwise, the squashed commit might give me the credits.

@oliviertassinari
oliviertassinari marked this pull request as ready for review December 5, 2020 16:01
oliviertassinari
oliviertassinari commented Dec 5, 2020
View reviewed changes
Comment thread docs/next.config.js
Comment on lines +182 to +185
// traverse(pages, 'en');
LANGUAGES_SSR.forEach((userLanguage) => {
traverse(pages, userLanguage);
});

@oliviertassinari oliviertassinari Dec 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To revert before we merge:

Suggested change
// traverse(pages, 'en');
LANGUAGES_SSR.forEach((userLanguage) => {
traverse(pages, userLanguage);
});
traverse(pages, 'en');

@oliviertassinari

oliviertassinari commented Dec 5, 2020

Copy link
Copy Markdown
Member Author

Performance seems equivalent between next and this PR: https://www.webpagetest.org/video/compare.php?tests=201205_DiXM_60dc3e9800a353c5cca37c9fddd0e06b,201205_DiTF_12f76403859985b5141587d48a392ef6.

@oliviertassinari oliviertassinari mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrookes mbrookes mbrookes left review comments
@eps1lon eps1lon eps1lon requested changes

Assignees

No one assigned

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliviertassinari @mui-pr-bot @eps1lon @mbrookes