Skip to content

Revert "[docs] API pages i18n"#23581

Merged
eps1lon merged 5 commits into
mui:nextfrom
eps1lon:fix/docs-i18n
Nov 17, 2020
Merged

Revert "[docs] API pages i18n"#23581
eps1lon merged 5 commits into
mui:nextfrom
eps1lon:fix/docs-i18n

Conversation

@eps1lon

@eps1lon eps1lon commented Nov 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

#23214 does not work when all locales are deployed and introduced various changes that it didn't communicate. When we re-introduce it we need to test the full deploy like e.g. 67f0281 (#23281) and discuss the changes.

Also reverts part of #23569 which builds on top of #23214. I can't reason about this abstraction. Let's get the default branch in a green state and then replay the changes cleanly. Fixed with eps1lon#477

Closes #23577

@eps1lon eps1lon added the docs Improvements or additions to the documentation. label Nov 17, 2020
@eps1lon eps1lon mentioned this pull request Nov 17, 2020
Closed
@mui-pr-bot

mui-pr-bot commented Nov 17, 2020 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against 434a125

@github-actions github-actions Bot mentioned this pull request Nov 17, 2020
Closed
@mnajdova

mnajdova commented Nov 17, 2020

Copy link
Copy Markdown
Member

#23214 does not work when all locales are deployed

Should we try to fix this rather than revert the PR, or is the suggestion to reopen the PR and fix the issues before merging it?

Also reverts part of #23569 which builds on top of #23214. I can't reason about this abstraction. Let's get the default branch in a green state and then replay the changes cleanly.

I can take care of this, I have the changes necessary for both the old and the new infra for the API generation.

@eps1lon

eps1lon commented Nov 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Should we try to fix this rather than revert the PR, or is the suggestion to reopen the PR and fix the issues before merging it?

These are not opposite. We revert it and once we got time we fix it. But we're not leaving next in a broken state since we don't know how long a fix takes. Especially since some changes were not mentioned in the PR at all. So it might not just be bugs but also unintended changes.

I can take care of this, I have the changes necessary for both the old and the new infra for the API generation.

Great. Could you base them off of this PR? I'll merge this once the mergable state is green.

@eps1lon eps1lon mentioned this pull request Nov 17, 2020
Merged
@mnajdova

mnajdova commented Nov 17, 2020

Copy link
Copy Markdown
Member

Here it is eps1lon#477 seems like there weren't many changes not merged

@mnajdova mnajdova mentioned this pull request Nov 17, 2020
Merged
@eps1lon
eps1lon merged commit 8d04dbd into mui:next Nov 17, 2020
@eps1lon
eps1lon deleted the fix/docs-i18n branch November 17, 2020 15:30
@eps1lon eps1lon mentioned this pull request Dec 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs] Running docs:api on windows causes differences on new lines

3 participants

@eps1lon @mui-pr-bot @mnajdova