[Tooltip] Long press select text on iOS#23466
Merged
Merged
Conversation
oliviertassinari
added
type: bug
oliviertassinari
approved these changes
Nov 10, 2020
Contributor
Author
|
@oliviertassinari hi, haven't seen this type of failure before. is there something I have done incorrectly? |
Member
|
We work on this problem at #23464. |
Contributor
Author
|
ok, thank you for the information! |
eps1lon
previously requested changes
Nov 10, 2020
eps1lon
left a comment
eps1lon
left a comment
Member
There was a problem hiding this comment.
Looks good. The cleanup is a bit too eager though.
eps1lon
previously requested changes
Nov 11, 2020
oliviertassinari
force-pushed
the
tooltip-longpress-ios
branch
from
November 11, 2020 09:55
e6f0493 to
c176d2b
Compare
oliviertassinari
force-pushed
the
tooltip-longpress-ios
branch
from
November 11, 2020 09:57
c176d2b to
947b12c
Compare
eps1lon
previously requested changes
Nov 11, 2020
oliviertassinari
dismissed
eps1lon’s stale review
November 11, 2020 17:11
bug fixed and test case added
eps1lon
approved these changes
Nov 12, 2020
Member
|
Did somebody confirm this works on iOS? It's not working on iPadOS. The PR description might still be correct since iOS and iPadOS are different operating systems. Just want to make sure we don't think this fixed it on all touch devices. |
Member
|
I can confirm the PR fixes the behavior on these two simulators:
|
Member
Let's hope they're more accurate than firefox' touch simulators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a useRef for keeping track of old WebkitUserSelect. If placement of introducing the ref is incorrect, feedback is much appreciated!
Closes #23232