[ClickAwayListener] Fix mounting behavior in Portals in React 17#23367
Merged
eps1lon merged 4 commits intoNov 2, 2020
Conversation
Member
|
Will we backport #23311 too? |
Member
Author
Let's not stress this and take one step at a time. React 17 is just fresh and I have not seen a reason to rush this out. I'm not aware of any big feature that React 17 needs to be rolled out as soon as possible |
This reverts commit d2dd1e7.
Member
|
Agree, we don't need to rush it. I was wondering about the coming weeks. Should we allow developers to upgrade React and Material-UI independently? |
Member
Author
This is already possible. The main offender is npm 7. If you're upgrading npm and React 17 at the same time then you're on your own. |
eps1lon
marked this pull request as ready for review
November 2, 2020 11:12
Details of bundle changes.Comparing: 9196f19...e4216c1 Details of page changes
|
oliviertassinari
approved these changes
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23315
Closes #23215 (magic comment for codesandbox)
Test plan