[Icon] Disable translation, e.g Google Translate#23237
Merged
Merged
Conversation
Contributor
Author
|
I'm not sure why the test_browser-1 failed, help needed since I made a minor change only. |
oliviertassinari
changed the title
oliviertassinari
added
type: bug
oliviertassinari
approved these changes
Oct 25, 2020
Member
|
From the deploy preview, it still appears to be broken: |
Member
|
@mbrookes This is a different issue, the JavaScript doesn't load in your test case. |
eps1lon
previously requested changes
Oct 26, 2020
Contributor
Author
|
Thanks @oliviertassinari and @eps1lon Do I need to do something else? This is my first pull request here. |
eps1lon
previously requested changes
Oct 27, 2020
Member
|
@cbeltrangomez84 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
sujinleeme
pushed a commit
to sujinleeme/material-ui
that referenced
this pull request
Oct 28, 2020
sujinleeme
pushed a commit
to sujinleeme/material-ui
that referenced
this pull request
Oct 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the Icons avoid Google Chrome translation since it make it stop showing the Icon.
Resolves #23236
Resources:
Related to #22719