Merged
Conversation
github-actions
Bot
added
PR: out-of-date
mbrookes
marked this pull request as ready for review
October 23, 2020 23:40
github-actions
Bot
added
PR: out-of-date
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
mbrookes
marked this pull request as ready for review
November 15, 2020 15:40
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
oliviertassinari
approved these changes
Nov 16, 2020
Member
|
I couldn't spot anything major. Browser performance seems the same, build time on Netlify seems the same. Happy to be one step closer to a similar DX as https://vuetifyjs.com/zh-Hans/api/v-avatar/. |
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 17, 2020
This reverts commit 7fbaefa.
This was referenced Nov 17, 2020
Member
Premature celebration. Had to revert this PR (#23581) since it doesn't work when deployed with all locales. There are also some changes that I didn't see discussed so let's rewind and then replay slowly in little iterations not one big sweeping change. |
oliviertassinari
pushed a commit
that referenced
this pull request
Nov 25, 2020
oliviertassinari
pushed a commit
to oliviertassinari/material-ui
that referenced
this pull request
Nov 25, 2020
oliviertassinari
pushed a commit
to oliviertassinari/material-ui
that referenced
this pull request
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key files
Generate:
Translations:
Example API docs:
Render:
NB
The script exits early so only Accordion is updated, in order to make the PR easier to review (19 changed files rather than 400+). That will obviously need to be updated before it can be merged.