Skip to content

[docs] Add logarithmic slider demo#23076

Merged
oliviertassinari merged 3 commits into
mui:nextfrom
LorenzHenk:slider-demo-logarithmic
Oct 16, 2020
Merged

[docs] Add logarithmic slider demo#23076
oliviertassinari merged 3 commits into
mui:nextfrom
LorenzHenk:slider-demo-logarithmic

Conversation

@LorenzHenk

Copy link
Copy Markdown

This is one of the use cases I solved with the Slider component, I think it's a nice demo 🙂

grafik

@mui-pr-bot

mui-pr-bot commented Oct 15, 2020

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against d2db291

@oliviertassinari

Copy link
Copy Markdown
Member

I have my reservation about introducing this demo. While it looks great! I'm not sure it adds a lot compared to the existing ones, not sure if it's enough to counterbalance its weight (having to carry it in the future). Thoughts @mbrookes?

@LorenzHenk

Copy link
Copy Markdown
Author

@oliviertassinari to be honest, the existing scale demo with e^ always looked confusing to me.

x**10 is hard to imagine, which gets even more unclear through the exponential format + round.

I was hoping to clear things up for others with this additional demo. I think it's much easier to follow.

@mbrookes

Copy link
Copy Markdown
Member

I actually think this is a more practical example than the one that precedes it, so it could simply be a case of replace the existing scale demo with this one. (Without the broken valueLabel.)

@oliviertassinari

oliviertassinari commented Oct 15, 2020

Copy link
Copy Markdown
Member

@mbrookes Sounds good, we can swap. The broken value is fixed with #23075, only need to rebase.

@LorenzHenk
LorenzHenk force-pushed the slider-demo-logarithmic branch from e0bf381 to 52a3d74 Compare October 16, 2020 08:17
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation. label Oct 16, 2020
Comment thread docs/src/pages/components/slider/slider.md Outdated
@oliviertassinari
oliviertassinari merged commit c24b9e2 into mui:next Oct 16, 2020
@oliviertassinari

Copy link
Copy Markdown
Member

@LorenzHenk Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: slider Changes related to the slider.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants