Skip to content

[Skeleton] Move from lab to core#22740

Merged
mbrookes merged 3 commits into
mui:nextfrom
mbrookes:skeleton-move-to-core
Sep 26, 2020
Merged

[Skeleton] Move from lab to core#22740
mbrookes merged 3 commits into
mui:nextfrom
mbrookes:skeleton-move-to-core

Conversation

@mbrookes

@mbrookes mbrookes commented Sep 25, 2020

Copy link
Copy Markdown
Member

Breaking changes

  • [Skeleton] Move the component from the lab to the core. This component will become stable.

    -import Skeleton from '@material-ui/lab/Skeleton';
    +import Skeleton from '@material-ui/core/Skeleton';

@mbrookes mbrookes added breaking change Introduces changes that are not backward compatible. scope: skeleton Changes related to the skeleton. labels Sep 25, 2020
@mbrookes mbrookes added this to the v5 milestone Sep 25, 2020
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 25, 2020
@mui-pr-bot

mui-pr-bot commented Sep 25, 2020

Copy link
Copy Markdown

@material-ui/core: parsed: 0.00% 😍, gzip: +0.16%
@material-ui/lab: parsed: +0.12% , gzip: +0.20%

Details of bundle changes

Generated by 🚫 dangerJS against fff4b12

@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 25, 2020
@mbrookes
mbrookes marked this pull request as ready for review September 25, 2020 22:41
@mbrookes
mbrookes merged commit de5c502 into mui:next Sep 26, 2020
@Krasnopir

Copy link
Copy Markdown

Skeleton and Alert was moved from lab to core in 5.0.0-alpha.11
But after update i see, that Alert and Skeleton are enable from /core/ and also from /lab/

node_modules/@material-ui/lab/Skeleton
node_modules/@material-ui/core/Skeleton

@oliviertassinari

Copy link
Copy Markdown
Member

@Krasnopir If you import from the lab, you will get a deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. scope: skeleton Changes related to the skeleton.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants