[theme] Rename type to mode#22687
Merged
Merged
Conversation
mnajdova
marked this pull request as ready for review
September 21, 2020 17:41
mnajdova
added
the
breaking change
mbrookes
reviewed
Sep 21, 2020
| data-ga-event-category="header" | ||
| data-ga-event-action="dark" | ||
| > | ||
| {theme.palette.type === 'light' ? <Brightness4Icon /> : <Brightness7Icon />} |
Member
There was a problem hiding this comment.
That reminds me (and completely incidental to this PR), but we should really provide an option to return to the browser / system setting. At the moment, once a cookie is set, the mode is fixed.
mbrookes
approved these changes
Sep 22, 2020
mnajdova
commented
Sep 22, 2020
oliviertassinari
approved these changes
Sep 22, 2020
Member
There was a problem hiding this comment.
Look great. For the others that might wonder; yes dark mode seems everywhere :)
- https://theme-ui.com/color-modes/
- https://support.apple.com/en-us/HT208976
- https://stackoverflow.design/product/guidelines/conditional-classes/#dark-mode
- https://ant.design/docs/spec/dark
mbrookes
approved these changes
Sep 22, 2020
mnajdova
commented
Sep 22, 2020
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
Renames
theme.palette.typetotheme.palette.mode, to better follow the "dark mode" term that is usually used for describing this feature.import { createMuiTheme } from '@material-ui/core/styles'; -const theme = createMuitheme({palette: { type: 'dark' }}), +const theme = createMuitheme({palette: { mode: 'dark' }}),The changes are supported by the
adaptV4Theme()for easing the migrationPart of #20012