[test] Only run on push for master/next#22624
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Actually, how do we test that the pull request won't break the CI once merged into next/master?
My bad, it will work because we have opened a pull request (I hope).
@eps1lon What about we disable ⬇️ if we merge these changes?
So we get all the commits merged on next running? Right now, CircleCi cancel redundant commits on our default branch 🙃 (a bug?)
|
On the actual branches we shouldn't auto cancel so that we can identify which commits didn't merge cleanly. For PRs we already do that. CircleCI auto cancelling on branches in this remote is a bug. But I don't know how to reproduce it because I did not see it cancel all builds on
It will work because we still run on pushes for |
|
No bundle size changes comparing 8452e71...a87d4dc |
e287097 to
521bfb6
Compare

This is safer since we only ever added one new branch as a long-living branch while it's much more likely to accidentally push a new, large branch to the
upstreamremote (this repository).We don't cancel older pipelines if new commits are pushed to branches on this repo (so that we know that merging these commits produce a green build). We previously ignored known branches but #22620 and #22618 used a different naming scheme and queued hundreds of pipeline runs. Maybe we can cancel these via API.
For future self: