Skip to content

[test] Only run on push for master/next#22624

Merged
eps1lon merged 9 commits into
mui:nextfrom
eps1lon:test/ci-deny-allow-branches
Sep 17, 2020
Merged

[test] Only run on push for master/next#22624
eps1lon merged 9 commits into
mui:nextfrom
eps1lon:test/ci-deny-allow-branches

Conversation

@eps1lon

@eps1lon eps1lon commented Sep 16, 2020

Copy link
Copy Markdown
Member

This is safer since we only ever added one new branch as a long-living branch while it's much more likely to accidentally push a new, large branch to the upstream remote (this repository).

We don't cancel older pipelines if new commits are pushed to branches on this repo (so that we know that merging these commits produce a green build). We previously ignored known branches but #22620 and #22618 used a different naming scheme and queued hundreds of pipeline runs. Maybe we can cancel these via API.

For future self:

@eps1lon eps1lon added the test label Sep 16, 2020

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, how do we test that the pull request won't break the CI once merged into next/master?

@oliviertassinari

This comment has been minimized.

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, how do we test that the pull request won't break the CI once merged into next/master?

My bad, it will work because we have opened a pull request (I hope).

@eps1lon What about we disable ⬇️ if we merge these changes?

Capture d’écran 2020-09-16 à 22 02 30

So we get all the commits merged on next running? Right now, CircleCi cancel redundant commits on our default branch 🙃 (a bug?)

@eps1lon

eps1lon commented Sep 16, 2020

Copy link
Copy Markdown
Member Author

On the actual branches we shouldn't auto cancel so that we can identify which commits didn't merge cleanly. For PRs we already do that. CircleCI auto cancelling on branches in this remote is a bug. But I don't know how to reproduce it because I did not see it cancel all builds on l10n_next

My bad, it will work because we have opened a pull request (I hope).

It will work because we still run on pushes for next and master. The normal behavior shouldn't change with this PR. Just how we treat new/unknown branches in this remote (https://github.com/mui-org/material-ui).

@mui-pr-bot

mui-pr-bot commented Sep 17, 2020

Copy link
Copy Markdown

No bundle size changes comparing 8452e71...a87d4dc

Generated by 🚫 dangerJS against a87d4dc

@eps1lon
eps1lon force-pushed the test/ci-deny-allow-branches branch from e287097 to 521bfb6 Compare September 17, 2020 09:31
@eps1lon
eps1lon merged commit 835a93d into mui:next Sep 17, 2020
@eps1lon
eps1lon deleted the test/ci-deny-allow-branches branch September 17, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants