[docs] Use codesandbox deploy for demos created from deploy previews#22616
Merged
Conversation
oliviertassinari
approved these changes
Sep 16, 2020
oliviertassinari
left a comment
oliviertassinari
left a comment
Member
There was a problem hiding this comment.
Nice! It's exactly what we discussed a few months ago with @mnajdova when she was working on the CSS utility classes and couldn't test it in code sandbox.
Member
Author
Right, I already forgot. Though you could always test it. You just had to know where to look for. Discoverability was almost non-existent. Hope this improves things. We'll need to make sure the deploy works. Booleans in environment variables are always a bit sketchy. |
oliviertassinari
pushed a commit
that referenced
this pull request
Oct 9, 2020
This was referenced Nov 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a codesandbox from a demo in a netlify deploy preview i.e. deployed PRs we'll now use the packages built from the same PR. Before you would always create demos using the latest published version on NPM.
I could've used this a couple of times in the past when doing extensive manual testing i.e. manual e2e testing. Our capabilities are already limited for local testing but you could always work around it. It's more a convenience functionality when reviewing PRs.
Downside:
Alternative:
Leave original functionality untouched but add an extra button in the "misc menu" for creating the demo using codesandbox deploys.