[slider] Simplify integration with form libraries#22548
Merged
Conversation
Contributor
Author
|
Should we also change |
youjingwong
force-pushed
the
slider-name-missing
branch
from
September 10, 2020 06:49
cdde499 to
34a9179
Compare
eps1lon
previously requested changes
Sep 10, 2020
eps1lon
left a comment
eps1lon
left a comment
Member
There was a problem hiding this comment.
Note that onChange isn't a actual change event listener. The target and currentTarget can be arbitrary elements.
oliviertassinari
left a comment
oliviertassinari
left a comment
Member
There was a problem hiding this comment.
Should we also change onChangeCommitted?
No, I don't think so. The motivation is to make the component behave more closely to a native range slider.
oliviertassinari
changed the title
oliviertassinari
added
the
type: new feature
oliviertassinari
force-pushed
the
slider-name-missing
branch
from
September 10, 2020 23:14
2a38546 to
fc8bc99
Compare
oliviertassinari
approved these changes
Sep 10, 2020
Contributor
Author
|
The failing tests should not be related to this PR. How do I get this merged? Do I need to rebase? |
Member
|
@NoNonsense126 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
2 tasks
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13485