[core] Remove onRendered from Modal and Portal#22464
Merged
Merged
Conversation
eps1lon
added
breaking change
oliviertassinari
approved these changes
Sep 3, 2020
42 tasks
oliviertassinari
added
scope: portal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
onRenderedfrom Modal and PortalDepending on your use case either use a callback ref on the child element or an effect hook in the child component.
Planned removal (see #20012) and #16262 (comment) for context.
We haven't had any use case internally and for app code callback refs and effect hooks exist.