Skip to content

[internal] Move utils package to TypeScript#22367

Merged
oliviertassinari merged 12 commits into
mui:nextfrom
oliviertassinari:add-typescript-utils-coverage
Aug 31, 2020
Merged

[internal] Move utils package to TypeScript#22367
oliviertassinari merged 12 commits into
mui:nextfrom
oliviertassinari:add-typescript-utils-coverage

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Aug 26, 2020

Copy link
Copy Markdown
Member

Migrate @material-ui/utils to TypeScript to unlock #22346.

@oliviertassinari oliviertassinari added typescript internal Behind-the-scenes enhancement. Formerly called “core”. labels Aug 26, 2020
@oliviertassinari
oliviertassinari force-pushed the add-typescript-utils-coverage branch 6 times, most recently from fcf584f to 308ed05 Compare August 26, 2020 13:59
@oliviertassinari
oliviertassinari marked this pull request as ready for review August 26, 2020 13:59
@mui-pr-bot

mui-pr-bot commented Aug 26, 2020

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against ddb8950

Comment thread packages/material-ui-utils/package.json
Comment thread packages/material-ui-utils/package.json Outdated
Comment thread packages/material-ui-utils/src/HTMLElementType.ts Outdated
Comment thread packages/material-ui-utils/src/chainPropTypes.ts Outdated
Comment thread packages/material-ui-utils/src/chainPropTypes.ts Outdated
Comment thread packages/material-ui-utils/src/deepmerge.ts Outdated
Comment thread packages/material-ui-utils/src/elementAcceptingRef.ts Outdated
Comment thread packages/material-ui-utils/src/elementTypeAcceptingRef.test.tsx Outdated
Comment thread packages/material-ui-utils/src/elementTypeAcceptingRef.test.tsx Outdated
Comment thread packages/material-ui-utils/src/elementTypeAcceptingRef.ts Outdated
@oliviertassinari
oliviertassinari force-pushed the add-typescript-utils-coverage branch 3 times, most recently from bb3c272 to 1bfb03c Compare August 28, 2020 10:31
@oliviertassinari
oliviertassinari dismissed eps1lon’s stale review August 28, 2020 11:41

I have fixed what I could

@eps1lon eps1lon self-assigned this Aug 30, 2020
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 31, 2020
@oliviertassinari
oliviertassinari force-pushed the add-typescript-utils-coverage branch from 4a699c0 to ddb8950 Compare August 31, 2020 13:04
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 31, 2020

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@oliviertassinari
oliviertassinari force-pushed the add-typescript-utils-coverage branch from 616e65f to ddb8950 Compare August 31, 2020 13:46
@oliviertassinari
oliviertassinari merged commit 6445fb2 into mui:next Aug 31, 2020
@oliviertassinari
oliviertassinari deleted the add-typescript-utils-coverage branch August 31, 2020 13:46
@oliviertassinari oliviertassinari changed the title [core] Move utils package to TypeScript [internal] Move utils package to TypeScript Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants