[test] Make all tests runnable with React 17#22290
Merged
Merged
Conversation
|
No bundle size changes comparing 0a84c37...e6378da |
This reverts commit 413b765.
oliviertassinari
approved these changes
Aug 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codebase is now fully compatible with the current React 17 release candidate.
We need to wrap unmount actions in
actdue to React 17 lazily calling cleanup functions from effects. Otherwise these would be called in between tests making it incredibly hard to find out which test caused a possible error. Sometimes they would also not run at all (in JSDOM) leading intervals running forever and mocha not exiting. It's also safer to flush them in the test or hook so that tests are better isolated.