[TrapFocus] Prevent possible crash in React 17#22262
Merged
eps1lon merged 1 commit intoAug 19, 2020
Merged
Conversation
eps1lon
added
type: bug
oliviertassinari
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a part of the
react@nextpatch into our release.This makes it easier to test our v5 with React 17. Will backport it to
mastersince it's fairly cheap.I think generally we won't recommend the next v4 release for production anyway. It's for deprecations only and if we introduce bugs in that release we don't want to put time into fixing those anyway. It's only meant as a migration helper.