Skip to content

[CircularProgress] Remove static variant, simplify determinate#22060

Merged
eps1lon merged 1 commit into
mui:nextfrom
mbrookes:circularprogress-remove-static-variant
Aug 7, 2020
Merged

[CircularProgress] Remove static variant, simplify determinate#22060
eps1lon merged 1 commit into
mui:nextfrom
mbrookes:circularprogress-remove-static-variant

Conversation

@mbrookes

@mbrookes mbrookes commented Aug 3, 2020 •
edited by oliviertassinari
Loading

Copy link
Copy Markdown
Member

Breaking change

  • The static variant has been merged into the determinate variant, with the latter assuming the appearance of the former.
    The removed variant was rarely useful. It was an exception to Material Design, and was removed from the specification.

    -<CircularProgress variant="determinate" />
    -<CircularProgress variant="static" classes={{ static: 'className' }} />
+<CircularProgress variant="determinate" classes={{ determinate: 'className' }} />

NB: If you had previously customized determinate, your customizations are probably no longer valid. Please remove them.

Motivation: #7223 (comment)
Closes #20548

@mbrookes mbrookes added breaking change Introduces changes that are not backward compatible. component: CircularProgress The React component. labels Aug 3, 2020
oliviertassinari
oliviertassinari reviewed Aug 3, 2020
View reviewed changes

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably leave a note in the migration guide

Comment thread packages/material-ui/src/CircularProgress/CircularProgress.test.js
@mui-pr-bot

mui-pr-bot commented Aug 3, 2020 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against bcf3ee0

@mbrookes

This comment has been minimized.

Sign in to view
@mbrookes mbrookes added this to the v5 milestone Aug 4, 2020
@oliviertassinari oliviertassinari mentioned this pull request Aug 4, 2020
Closed
oliviertassinari
oliviertassinari reviewed Aug 5, 2020
View reviewed changes
Comment thread docs/src/pages/guides/migration-v4/migration-v4.md
oliviertassinari
oliviertassinari reviewed Aug 6, 2020
View reviewed changes
Comment thread docs/src/pages/guides/migration-v4/migration-v4.md
mbrookes
mbrookes commented Aug 6, 2020
View reviewed changes
Comment thread docs/src/pages/guides/migration-v4/migration-v4.md Outdated
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 6, 2020
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 6, 2020
@github-actions github-actions Bot mentioned this pull request Aug 6, 2020
Closed
@mbrookes mbrookes mentioned this pull request Aug 6, 2020
Merged
1 task
@eps1lon
eps1lon merged commit 5e12d7c into mui:next Aug 7, 2020
@mbrookes
mbrookes deleted the circularprogress-remove-static-variant branch August 7, 2020 17:56
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@oliviertassinari oliviertassinari mentioned this pull request Jan 27, 2021
Closed
2 tasks
@oliviertassinari oliviertassinari added the scope: progress Changes related to the progress. label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. component: CircularProgress The React component. scope: progress Changes related to the progress.

Projects

None yet

Milestone

v5.0.0-beta.0

Development

Successfully merging this pull request may close these issues.

[CircularProgress] Remove determinate variant

4 participants

@mbrookes @mui-pr-bot @oliviertassinari @eps1lon