Skip to content

[core] Small changes#22020

Merged
oliviertassinari merged 18 commits into
mui:nextfrom
oliviertassinari:batch-small-changes-v26
Aug 4, 2020
Merged

[core] Small changes#22020
oliviertassinari merged 18 commits into
mui:nextfrom
oliviertassinari:batch-small-changes-v26

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Aug 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
  • [core] import * as React from 'react' a1d5aeb: Noticed a few cases that diverge from the convention
  • [core] Resolve hesitation between @return vs. @returns 7913d02: the two are aliases, I went with @returns because more popular (in the codebase).
  • [core] Remove blank line for consistency 8d0d352: follow the convention
  • [test] Fix test:coverage:html 7b3faab: the command got out of date
  • [core] Sort gitignore ASC e1e52df: so we don't have to ask ourselves, where should I put the new value.
  • [docs] Simpler > easier c851384: simple: one bread, easy: no effort. Isn't simplicity a better property to aim for than easiness?
  • [docs] v5 in Q3 is unrealistic 2f135bd
  • [core] Point to next over master c4fcc2a:
  • [docs] We don't allow the .jsx extension 4b15574:
  • [job] Add levels 07d64fb:
  • [docs] Skip anchor link for h1 9b980c7: the anchor on the h1 duplicates with the naked URL, it's noise. I found it with Algolia that always returns an anchor even when it matches the top of the page. reactjs.org does the same, docusaurus.io and many others too.
  • [test] Improve lint commands 3e1442b: a small detail we changed in the x repository so we could add a CSS lint stage.

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Aug 1, 2020
This was referenced Aug 1, 2020
Merged
Merged
eps1lon
eps1lon requested changes Aug 1, 2020
View reviewed changes
Comment thread .circleci/config.yml Outdated
@github-actions github-actions Bot mentioned this pull request Aug 1, 2020
Closed
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 2, 2020
mbrookes
mbrookes reviewed Aug 2, 2020
View reviewed changes
Comment thread docs/src/pages/company/software-engineer/software-engineer.md Outdated
oliviertassinari and others added 17 commits August 2, 2020 16:00
@oliviertassinari
oliviertassinari force-pushed the batch-small-changes-v26 branch from cbb3459 to 0128956 Compare August 2, 2020 14:02
@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 2, 2020
@mui-pr-bot

mui-pr-bot commented Aug 2, 2020 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against 144bf74

eps1lon
eps1lon previously requested changes Aug 3, 2020
View reviewed changes
Comment thread package.json Outdated
@oliviertassinari
oliviertassinari force-pushed the batch-small-changes-v26 branch from 4b0ee49 to 144bf74 Compare August 3, 2020 13:34
@oliviertassinari
oliviertassinari merged commit e1e8e82 into mui:next Aug 4, 2020
@oliviertassinari
oliviertassinari deleted the batch-small-changes-v26 branch August 4, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrookes mbrookes mbrookes left review comments
@eps1lon eps1lon eps1lon left review comments

Assignees

No one assigned

Labels

umbrella For grouping multiple issues to provide a holistic view

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliviertassinari @mui-pr-bot @mbrookes @eps1lon