[Avatar] Rename variant circle -> circular for consistency#22015
Merged
oliviertassinari merged 5 commits intoAug 3, 2020
Conversation
kodai3
changed the title
kodai3
changed the title
oliviertassinari
added
breaking change
oliviertassinari
approved these changes
Aug 1, 2020
eps1lon
previously requested changes
Aug 1, 2020
eps1lon
left a comment
eps1lon
left a comment
Member
There was a problem hiding this comment.
yarn workspace framer build should fix CI.
Contributor
Author
|
@eps1lon |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
eps1lon
approved these changes
Aug 2, 2020
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Oh, I have to fix migration.md |
Contributor
Author
|
I updated the migration file and PR description |
…r-variant-consistency
This was referenced Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
circletocircularfor consistency. The possible values should be adjectives, not nouns:One item of #21964