Skip to content

[TextareaAutosize] Rename rowsMax->maxRows & rowsMin->minRows#21873

Merged
oliviertassinari merged 3 commits into
mui:nextfrom
mhayk:next
Aug 3, 2020
Merged

[TextareaAutosize] Rename rowsMax->maxRows & rowsMin->minRows#21873
oliviertassinari merged 3 commits into
mui:nextfrom
mhayk:next

Conversation

@mhayk

@mhayk mhayk commented Jul 21, 2020 •
edited by oliviertassinari
Loading

Copy link
Copy Markdown
Contributor

Breaking changes

TextField

  • Rename rowsMax prop with maxRows for consistency with HTML attributes.

    -<TextField rowsMax={6}>
+<TextField maxRows={6}>

TextareaAutosize

  • Rename rowsMax prop with maxRows for consistency with HTML attributes.

    -<TextareAutosize rowsMax={6}>
+<TextareAutosize maxRows={6}>

  • Rename rowsMin prop with minRows for consistency with HTML attributes.

    -<TextareAutosize rowsMin={1}>
+<TextareAutosize minRows={1}>

Part of #20012

@mui-pr-bot

mui-pr-bot commented Jul 21, 2020 •
edited
Loading

Copy link
Copy Markdown

Details of bundle changes

Generated by 🚫 dangerJS against 322ff33

oliviertassinari
oliviertassinari reviewed Jul 21, 2020
View reviewed changes

@oliviertassinari oliviertassinari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting working on it, we would also need to handle rowsMin -> minRows

@oliviertassinari oliviertassinari added component: TextareaAutosize The React component. breaking change Introduces changes that are not backward compatible. labels Jul 21, 2020
@mhayk mhayk changed the title [TextareaAutosize] Rename rowsMax -> maxRows for consistency [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows for consistency Jul 21, 2020
@mhayk

mhayk commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

@oliviertassinari done! 👊

@oliviertassinari

oliviertassinari commented Jul 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@dmtrKovalenko Any idea on the fail with the DatePicker? https://app.circleci.com/pipelines/github/mui-org/material-ui/15930/workflows/3b1b360c-2f3b-4482-b5f0-afed19f04433/jobs/165238

What about we hold this pull request, and we upgrade the dependency on the pickers from v3 to the last alpha release? At the minimum, it will move us in the right direction.

Capture d’écran 2020-07-22 à 12 49 13

@dmtrKovalenko

dmtrKovalenko commented Jul 22, 2020

Copy link
Copy Markdown
Collaborator

It is a typescript error caused by conflict in typings.

Yes upgrading pickers will solve the issue

@oliviertassinari

oliviertassinari commented Jul 22, 2020

Copy link
Copy Markdown
Member

Alright, let's try the upgrade in another pull request and keep this one on hold :).
@dmtrKovalenko do you want to take care of it?

This was referenced Jul 25, 2020
Closed
Merged
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 2, 2020
@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 2, 2020
@github-actions github-actions Bot mentioned this pull request Aug 2, 2020
Closed
@oliviertassinari oliviertassinari changed the title [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows for consistency [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows Aug 2, 2020
@oliviertassinari oliviertassinari changed the title [TextareaAutosize] Rename rowsMax -> maxRows / rowsMin -> minRows [TextareaAutosize] Rename rowsMax->maxRows & rowsMin->minRows Aug 2, 2020
@oliviertassinari oliviertassinari mentioned this pull request Aug 2, 2020
Closed
@oliviertassinari oliviertassinari mentioned this pull request Aug 2, 2020
Closed
@oliviertassinari
oliviertassinari merged commit 6e26b3c into mui:next Aug 3, 2020
@oliviertassinari

oliviertassinari commented Aug 3, 2020

Copy link
Copy Markdown
Member

@mhayk Thanks!

kodai3 pushed a commit to kodai3/material-ui that referenced this pull request Aug 3, 2020
@mhayk @kodai3
[TextareaAutosize] Rename rowsMax->maxRows & rowsMin->minRows (mui#21873
034ed15 
)
@eps1lon eps1lon added this to the v5 milestone Aug 4, 2020
@eps1lon eps1lon mentioned this pull request Aug 5, 2020
Closed
42 tasks
@mbrookes

mbrookes commented Oct 15, 2020

Copy link
Copy Markdown
Member

@mhayk Thanks for working on this. Would you be happy to work on adding a deprecation warning on the master branch?

@mhayk

mhayk commented Oct 15, 2020

Copy link
Copy Markdown
Contributor Author

Hey @mbrookes! Of course! I am going to do that .. thank you to invite me!

@mbrookes

mbrookes commented Oct 16, 2020

Copy link
Copy Markdown
Member

@mhayk That's great, thanks! If you need any pointers, you can check other examples that have already been completed: #20012

@mbrookes

mbrookes commented Nov 14, 2020

Copy link
Copy Markdown
Member

Hey @mhayk! 👋 Just checking if you still plan to work on adding a deprecation warning for v4? Thanks!

@mhayk

mhayk commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

Hi @mbrookes .. sorry for the delay .. #23530. Could you review please ?

@mbrookes

mbrookes commented Nov 15, 2020

Copy link
Copy Markdown
Member

@mhayk No need to apologize - thanks for working on it! It looks like there might be a couple of CI issues to fix. If the errors don't make sense, feel free to ping me on the PR, and I'll take a look.

@oliviertassinari oliviertassinari mentioned this pull request Nov 24, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. component: TextareaAutosize The React component.

Projects

None yet

Milestone

v5.0.0-beta.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mhayk @mui-pr-bot @oliviertassinari @dmtrKovalenko @mbrookes @eps1lon