[Grid] Rename justify prop to justifyContent#21845
Merged
Merged
Conversation
oliviertassinari
added
the
breaking change
oliviertassinari
approved these changes
Jul 19, 2020
Co-authored-by: Olivier Tassinari <[email protected]>
Member
Author
|
@oliviertassinari how can I see more logs from the test failiars? I cannot repro locally 😕 |
Member
|
@mnajdova Do you have enough right to rerun the builds? Seemed to be enough. |
This comment has been minimized.
This comment has been minimized.
|
This breaking change need not to happen: you could equally support justify and justifyContent and keep old code working. |
Member
|
@davidpham87 That will be done as a deprecation in v4. |
oliviertassinari
pushed a commit
to oliviertassinari/material-ui
that referenced
this pull request
Dec 20, 2020
oliviertassinari
pushed a commit
to oliviertassinari/material-ui
that referenced
this pull request
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Rename
justifyprop withjustifyContentto be aligned with the CSS property name.It should also help reduce the API gap with the props of the
<Box />.