Skip to content

fix circular progress issue#2040

Closed
chrismcv wants to merge 1 commit intomui:masterfrom
chrismcv:fix-progress
Closed

fix circular progress issue#2040
chrismcv wants to merge 1 commit intomui:masterfrom
chrismcv:fix-progress

Conversation

@chrismcv
Copy link
Copy Markdown
Contributor

@chrismcv chrismcv commented Nov 2, 2015

@oliviertassinari you can recreate on the docs page actually!

this fixes

@oliviertassinari
Copy link
Copy Markdown
Member

oliviertassinari commented Nov 2, 2015

The warnings are gone be the circular progress doesn't behave correctly. Can you confirm?

@chrismcv
Copy link
Copy Markdown
Contributor Author

chrismcv commented Nov 2, 2015

@oliviertassinari - it's behaving the same as material-ui.com - is that what you mean?

@oliviertassinari
Copy link
Copy Markdown
Member

oliviertassinari commented Nov 2, 2015

nov 02 2015 21 49

@chrismcv
Copy link
Copy Markdown
Contributor Author

chrismcv commented Nov 2, 2015

had to remove the auto-prefixer stuff - think it is resetting the transition property which is causing the odd pause. I'm not certain what the impact is...

oliviertassinari
oliviertassinari reviewed Nov 2, 2015
View reviewed changes
src/circular-progress.jsx Outdated
Copy link
Copy Markdown
Member

@oliviertassinari oliviertassinari Nov 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.o

@oliviertassinari
Copy link
Copy Markdown
Member

oliviertassinari commented Nov 2, 2015

I can't merge this, it's no longer autoprefixed. Can't we do the same things as https://github.com/callemall/material-ui/pull/2007/files#diff-7b0d10ffdd18b87263fab49840fec31cR286?
@Cavitt Any clue on this?

@chrismcv
Copy link
Copy Markdown
Contributor Author

chrismcv commented Nov 2, 2015

yes, although that is what was deleted....
https://github.com/callemall/material-ui/pull/2007/files#diff-0c1cb3bd2e3790000eb7598137a363a7L102

@oliviertassinari oliviertassinari mentioned this pull request Nov 2, 2015
Closed
@chrismcv
Copy link
Copy Markdown
Contributor Author

chrismcv commented Nov 3, 2015

@oliviertassinari think this one should be good to merge now

@oliviertassinari oliviertassinari mentioned this pull request Nov 3, 2015
Merged
@oliviertassinari
Copy link
Copy Markdown
Member

oliviertassinari commented Nov 3, 2015

See #2047

@chrismcv chrismcv deleted the fix-progress branch February 1, 2016 21:13
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@dependabot-preview
Bump cypress from 4.10.0 to 4.11.0 (mui#2040)
9cbcb42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrismcv @oliviertassinari