[TableRow] Improve hover/selected styles#19277
Merged
Merged
Conversation
Details of bundle changes.Comparing: 58d7fd9...aa4fe26
|
oliviertassinari
changed the title
oliviertassinari
added
scope: table
Member
|
@eps1lon It sounds like our wish has been answered :). We can put the infrastructure in place for |
oliviertassinari
added
the
design: material
oliviertassinari
force-pushed
the
feature/table-row-style
branch
from
January 21, 2020 11:26
02dd837 to
aa4fe26
Compare
oliviertassinari
approved these changes
Jan 21, 2020
oliviertassinari
left a comment
oliviertassinari
left a comment
Member
There was a problem hiding this comment.
I have updated the values in the theme to match the specification. It's a sensitive change, better wait for the next minor to release it (avoid patches).
eps1lon
approved these changes
Jan 21, 2020
eps1lon
left a comment
eps1lon
left a comment
Member
There was a problem hiding this comment.
Well I'm not sure what caused the change of mind but at least we have one issue out of the way. Time to look into the Button spec again.
Member
@eps1lon I think that the new (unless I have missed it) specification page on the visual states had a great influence :). |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Jan 23, 2020
This was referenced Mar 20, 2020
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10870 (comment)