[core] Distinguish JSSProperties and CSSProperties#19263
Merged
Conversation
eps1lon
added
docs
|
No bundle size changes comparing f1080b6...78f5ec8 |
eps1lon
changed the title
merceyz
reviewed
Jan 17, 2020
eps1lon
force-pushed
the
fix/distinguish-css-properties
branch
2 times, most recently
from
January 17, 2020 12:24
604e5bb to
dbe9756
Compare
eps1lon
force-pushed
the
fix/distinguish-css-properties
branch
from
January 20, 2020 11:13
dbe9756 to
d345232
Compare
eps1lon
commented
Jan 20, 2020
1 task
This was referenced Mar 20, 2020
2 tasks
This was referenced Apr 6, 2020
This was referenced Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our internal "CSSProperties" are tied to our particular CSS-in-JS implementation. However, in some places (e.g. https://github.com/mui-org/material-ui/blob/75c06bcda7fdc6bd316d3d8c196c0d1ce94905cc/docs/src/pages/components/selects/MultipleSelect.tsx#L100 or https://github.com/mui-org/material-ui/blob/0d10a7b9ba1a9b4e61ffd2c2b194f39e03f2e180/docs/src/pages/customization/components/DynamicInlineStyle.tsx#L44) this type is passed to
styleattributes. It works right now but is the wrong abstraction and blocks experimental type refactorings to address #19113