Skip to content

Fix an issue caused by RTL Support#1922

Merged
oliviertassinari merged 2 commits intomui:masterfrom
louy:patch-2
Oct 19, 2015
Merged

Fix an issue caused by RTL Support#1922
oliviertassinari merged 2 commits intomui:masterfrom
louy:patch-2

Conversation

@louy
Copy link
Copy Markdown
Contributor

@louy louy commented Oct 19, 2015

This is an alternative to #1921. Fixes #1918.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliviertassinari
Copy link
Copy Markdown
Member

I'm fine with it. @shaurya947?

@louy
Copy link
Copy Markdown
Contributor Author

louy commented Oct 19, 2015

You're right. I'm still not sure how adding contextTypes to <Clock> solved it however.

@shaurya947
Copy link
Copy Markdown
Contributor

I'm fine with it too. @oliviertassinari feel free to merge this!

oliviertassinari added a commit that referenced this pull request Oct 19, 2015
Fix an issue caused by RTL Support
@oliviertassinari oliviertassinari merged commit 72aa406 into mui:master Oct 19, 2015
@jlebensold
Copy link
Copy Markdown

@louy @oliviertassinari I think there's a bug in the prepareStyles method: https://github.com/callemall/material-ui/blame/v0.12.4/src/mixins/style-propable.js#L36

the example from the documentation for <AppBar /> rendering <NavigationClose /> no longer works and triggers an invariance warning: https://github.com/callemall/material-ui/blob/50b4a5b780e3e9dde591fea200226236d62eeb87/docs/src/app/components/raw-code/app-bar-code.txt#L7

I traced it down to the <SvgIcon /> component, which relies on StylePropable.

@shaurya947
Copy link
Copy Markdown
Contributor

@jlebensold could you describe a little more as to how you produced the bug? I'll look into it then..

@louy
Copy link
Copy Markdown
Contributor Author

louy commented Oct 21, 2015

@jeinbensold is it a "you're calling ensureDirection twice" error?
If so, then it's not a bug in the method itself but an incorrect use of it somewhere.
Could you show us an example of that? Docs are working fine for me.

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
* Integrate cypress component tests

* Install latest cypress version

* Fix new tests

* Skip TimePicker tests
@zannager zannager added the docs Improvements or additions to the documentation. label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.12.4 doesn't work in strict mode

5 participants