Skip to content

[test] Only build component packages for codesandbox #17976

Merged
eps1lon merged 2 commits into
mui:masterfrom
eps1lon:ci/silent-codesandbox-2
Oct 25, 2019
Merged

[test] Only build component packages for codesandbox #17976
eps1lon merged 2 commits into
mui:masterfrom
eps1lon:ci/silent-codesandbox-2

Conversation

@eps1lon

@eps1lon eps1lon commented Oct 21, 2019

Copy link
Copy Markdown
Member

Without resolutions building styles would be pointless /core would still list the latest stable as its dependency.

@eps1lon eps1lon added the test label Oct 21, 2019
@mui-pr-bot

mui-pr-bot commented Oct 21, 2019

Copy link
Copy Markdown

No bundle size changes comparing 79fad65...c62a957

Generated by 🚫 dangerJS against c62a957

@eps1lon

eps1lon commented Oct 21, 2019

Copy link
Copy Markdown
Member Author

@CompuIves I expected codesandbox to still appear in the checks section. It is installed (according to GitHub UI):

Screenshot from 2019-10-21 16-02-21

@oliviertassinari

Copy link
Copy Markdown
Member

@eps1lon Should we try to uninstall/install?

@eps1lon

eps1lon commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

@eps1lon Should we try to uninstall/install?

Sounds like a good idea 👍

@oliviertassinari

Copy link
Copy Markdown
Member

uninstalled

@oliviertassinari

Copy link
Copy Markdown
Member

installed back

@oliviertassinari

Copy link
Copy Markdown
Member

It doesn't seem to work.

@eps1lon
eps1lon force-pushed the ci/silent-codesandbox-2 branch from 57a1c7a to f1b7217 Compare October 24, 2019 19:32
@eps1lon eps1lon changed the title [test] Mute codesandbox comment [test] Only build component packages for codesandbox Oct 24, 2019
@eps1lon

eps1lon commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

Hm we could make this work for our packages by patching the version in the package.json. I'll figure something out.

@eps1lon
eps1lon force-pushed the ci/silent-codesandbox-2 branch 2 times, most recently from 4d18b7d to 3c41ec1 Compare October 25, 2019 09:52
@eps1lon

eps1lon commented Oct 25, 2019

Copy link
Copy Markdown
Member Author

@CompuIves Using the same version doesn't work since codesandbox thinks the version string points to a package on the npm registry. https://codesandbox.io/s/create-react-app-52hbg

@eps1lon
eps1lon force-pushed the ci/silent-codesandbox-2 branch from 3c41ec1 to c62a957 Compare October 25, 2019 10:15
@eps1lon
eps1lon merged commit 1c6ea63 into mui:master Oct 25, 2019
@eps1lon

eps1lon commented Oct 25, 2019

Copy link
Copy Markdown
Member Author

For now we have a codesandbox for the most common use case I imagine (testing components). For styles we need to wait for resolutions. But this is already a great first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants