Fix local dev Docs server, add prd command to run build folder locally.#1774
Merged
shaurya947 merged 1 commit intomui:masterfrom Sep 30, 2015
Merged
Fix local dev Docs server, add prd command to run build folder locally.#1774shaurya947 merged 1 commit intomui:masterfrom
shaurya947 merged 1 commit intomui:masterfrom
Conversation
Contributor
NogsMPLS
commented
Sep 30, 2015
- Moved CSS directory into www directory.
- Changed index.html to reference new path to main.css
- Changed dev server contentBase and buildPath to 'src/www'
- Removed TransferWebpackPlugin in dev server config, as it wasn't doing anything anyways and is a current open issue here: Using webpack dev server the files are not moved dkokorev90/transfer-webpack-plugin#6
- Added a 'npm run prd' command in package.json to run the 'build' folder if people want to test what will be in prd vs. dev.
- Should hopefully close [Documentation] Local Dev Server Broken #1772
Contributor
Author
|
NOTE: Only tested on Windows 7. Still needs to be test on Mac/Linux since directory/paths changed slightly. Ideally a brand new pull, but at least a deletion of the 'build' directory and 'npm run build' should be performed. Though, it should technically work even without doing that, would just have extraneous files sitting around. |
Contributor
|
@NogsMPLS let me test this on my Mac |
Contributor
|
Confirming that this works in MacOS X 10.9.5 on Chrome 45.0.2454.101 (64-bit) Thanks @NogsMPLS |
shaurya947
added a commit
that referenced
this pull request
Sep 30, 2015
Fix local dev Docs server, add prd command to run build folder locally.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.