React 0.14 support#1770
Conversation
cgestes
commented
Sep 30, 2015
cgestes
commented
- add missing dependencies to the docs project. npm 3 do not install peerDependencies automatically anymore.
- fixes for react-router 1.0
Only application (that wont be used as npm modules) should declare peerDependencies as real dependencies to bring them to the build. NPM 3 do not install peerDependencies anymore.
|
These dependences are already in the root package.json. Now, they are duplicated, what's the benefit? |
|
@oliviertassinari npm 3 do not install peerDependencies anymore. so to run the doc now you have to install them by hand. (btw I'am currently fixing react-router on the 0.14 branch) |
Ok thanks |
|
@cgestes this is complete now right (including all fixes for |
|
I hope so. |
|
btw the code editor is still broken on the doc project, but I think I saw a PR about so, I didn't touch anything. |
|
and ... the url are nicer than in master, but the webpack-dev-server is not able to serve them correctly, which means reloading a webpage does not work. we use localhost:3000/home instead of former localhost:3000/#/home |
|
I'll go ahead and merge this. Let's try running the docs site off this branch after I merge this and see what else is broken? |
Does this mean that in IE 8 and 9 the page is fully reloaded when changing route? |
|
Yep that's what the current strategy we use does. It is easy to change. We On Wed, Sep 30, 2015, 18:36 Olivier Tassinari [email protected]
|
* Support empty dates for the DatePicker
* Support empty dates for TimePicker
* Support empty dates for mobile toobars
* Support empty dates in YearSelection
* Introduce `toolbarPlaceholder` prop for customization of empty date text
* Add tests
* Do not dispatch `changeFocusedDay` on each mount
* Fix crashes when rendering empty date with luxon and moment
* [TimePicker] Do not throw validation error if value={null}
* Update props description for TimePicker validation props
* Refactor ternary operator to aviod negatiation
* Remove `defaultHighlight` prop
4 participants
