Merged
Conversation
test/drop-down-menu-spec.js
Outdated
Contributor
There was a problem hiding this comment.
Thanks @yulric! This looks good, except could you change the name of this unit test? So if x is the index of the selected value, then maybe something like:
shows value at index x as selected by default
I'll go ahead and merge this then :)
Contributor
Author
There was a problem hiding this comment.
Sure I'll do it tonight so it should be ready by tomorrow.
Contributor
Author
Contributor
|
thanks @yulric |
Contributor
Author
|
No problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.