Skip to content

Add canvasColor to theme palette#1762

Merged
shaurya947 merged 1 commit intomui:masterfrom
quanglam2807:canvas-color
Sep 29, 2015
Merged

Add canvasColor to theme palette#1762
shaurya947 merged 1 commit intomui:masterfrom
quanglam2807:canvas-color

Conversation

@quanglam2807
Copy link
Copy Markdown
Contributor

@shaurya947
Copy link
Copy Markdown
Contributor

@quanglam2807 you probably just need to update the last unit test.

Thanks for this. Could you make sure that you have updated all source files so that any kind of background property now uses the canvasColor instead of alternateTextColor?

@quanglam2807
Copy link
Copy Markdown
Contributor Author

@shaurya947 Actually, I changed the alternateTextColor to Colors.white so it failed the test and I have set it back to the original value so it's working now.
Also, I am pretty sure that I have changed all the background values of src and docs to canvasColor. No need to say thanks! Your work is amazing and I just want to help a little bit. 👍

shaurya947 added a commit that referenced this pull request Sep 29, 2015
Add canvasColor to theme palette
@shaurya947 shaurya947 merged commit 4066e74 into mui:master Sep 29, 2015
@zannager zannager added the customization: theme Higher level theming customizability. label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customization: theme Higher level theming customizability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants