[docs] Revert hits per page change#17458
Merged
Merged
Conversation
Details of bundle changes.Comparing: daac056...7268555
|
Member
Author
|
Yeah I don't understand how these resultsets are agregated. Setting it to 5 will display 2 links to the input API but setting it to 40 will display all. Couldn't find any documentation for that and don't want to spend more time on it. I would just recommend to use another search engine for searching the docs. |
Member
|
I start to wonder if most people don't query on Google directly. The query "material-ui" accounts for 10% of our SEO traffic. The usage of Algolia, from the stats, is strange. About 25% of our users, for a given month, do at least one search. Shouldn't this number be higher? 🤔 I'm wondering what value this metric has on the other projects. |
oliviertassinari
approved these changes
Sep 17, 2019
nrkroeker
added a commit
to nrkroeker/material-ui
that referenced
this pull request
Sep 18, 2019
* [docs] Batch small changes (mui#17435) * [docs] Add synonyms for brand icons (mui#17455) * [docs] Add synonyms for brand icons * Remove Ic prefixed icons * [docs] Improve in-site search (mui#17450) * [ButtonBase] Fix blurry text issue (mui#17453) * [docs] Revert hits per page change (mui#17458) * [docs] Fix heading format in CONTRIBUTING.md (mui#17460) * [Chip] Load the right version of Avatar (mui#17469) * [TablePagination] Merge root classes properly (mui#17467) * [Breadcrumbs] Improve API docs (mui#17468) * [TextField] Handle Chrome autofill (mui#17436) * [docs] Clarify props spread for ListItem when button flag is set (mui#17466)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change of
hitsPerPagein #17450 had some unintended side-effects. The goal was to make large resultsets pageable but it also changed how these resultsets are created. It is the documented, recommended approach for pagination of algolia results but I would never expect pagination to change what results are displayed or in which order. It should only add more i.e. if I had 5 before and extend it to 10 the first 5 should stay the same.For example all results for
iconslinked to https://material-ui.netlify.com/components/icons/. Extending tohitsPerPageshould've made it possible to scroll past a single page. Unfortunately it changed the resultset of e.g.inputwhich now links to https://material-ui.netlify.com/api/input/ in the first 6 results where it only displayed 2 previously.Looks like the default is 2 which would've made it clear that this is no pure pagination option.