[docs] Batch small changes#17435
Merged
oliviertassinari merged 9 commits intoSep 16, 2019
Merged
Conversation
Details of bundle changes.Comparing: 3103cc3...44dcb54
|
oliviertassinari
force-pushed
the
batch-small-changes-v12
branch
from
September 15, 2019 13:11
05cf3a5 to
ed138fb
Compare
eps1lon
previously requested changes
Sep 15, 2019
eps1lon
left a comment
eps1lon
left a comment
Member
There was a problem hiding this comment.
[docs] All the components should forward the ref (5ba2f33): sync with the docs, open the opporunity for bug reports.
Some either don't do this or it isn't tested. This is why https://github.com/mui-org/material-ui/blob/0dd52ac0d614ab428f580b69ffe90c829c46d62b/docs/src/modules/utils/generateMarkdown.js#L302 exists.
Member
Author
|
Ok, thanks, I revert. |
We were mixing the two approaches. function > arrow was more popular in the codebase. https://softwareengineering.stackexchange.com/questions/364086/why-use-const-foo-instead-of-function-foo/364110#364110
oliviertassinari
force-pushed
the
batch-small-changes-v12
branch
from
September 15, 2019 13:18
ed138fb to
44dcb54
Compare
nrkroeker
added a commit
to nrkroeker/material-ui
that referenced
this pull request
Sep 18, 2019
* [docs] Batch small changes (mui#17435) * [docs] Add synonyms for brand icons (mui#17455) * [docs] Add synonyms for brand icons * Remove Ic prefixed icons * [docs] Improve in-site search (mui#17450) * [ButtonBase] Fix blurry text issue (mui#17453) * [docs] Revert hits per page change (mui#17458) * [docs] Fix heading format in CONTRIBUTING.md (mui#17460) * [Chip] Load the right version of Avatar (mui#17469) * [TablePagination] Merge root classes properly (mui#17467) * [Breadcrumbs] Improve API docs (mui#17468) * [TextField] Handle Chrome autofill (mui#17436) * [docs] Clarify props spread for ListItem when button flag is set (mui#17466)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [docs] All the components should forward the ref (5ba2f33): sync with the docs, open the opporunity for bug reports.