Skip to content

Change to ReactDOM.findDOMNode() and use separated react addon libs#1733

Closed
Aaike wants to merge 5 commits intomui:react-0.14-supportfrom
Aaike:update-react
Closed

Change to ReactDOM.findDOMNode() and use separated react addon libs#1733
Aaike wants to merge 5 commits intomui:react-0.14-supportfrom
Aaike:update-react

Conversation

@Aaike
Copy link
Copy Markdown
Contributor

@Aaike Aaike commented Sep 26, 2015

No description provided.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis complains: Error: Cannot find module 'react-stub-context'.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh react-stub-context hasn't been updated yet to react 0.14.
@shaurya947 said to just leave it out if it isn't used by the files source files : #1704

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this means that we can't fix the build until react-stub-context support react v0.14?
I will close #1725 when the build pass since I believe this PR is more appropriate.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aaike @oliviertassinari I suggested leaving it out because I thought that might fix the build error.

What can we do now to make the build successful?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaurya947 I'm gonna try to fix react-stub-context.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This was referenced Sep 28, 2015
@oliviertassinari
Copy link
Copy Markdown
Member

I think that we can close this PR since #1751 was merged.

@shaurya947 shaurya947 closed this Sep 30, 2015
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@zannager zannager added the docs Improvements or additions to the documentation. label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants