[docs] Migrate all public class component to function components#16693
Merged
joshwooding merged 29 commits intoJul 29, 2019
Merged
[docs] Migrate all public class component to function components#16693joshwooding merged 29 commits into
joshwooding merged 29 commits into
Conversation
The first passthrough of migrating all of the remaining class component doc examples to function components via hooks.
|
No bundle size changes comparing 8c28ed9...45786d3 |
oliviertassinari
changed the title
bpas247
marked this pull request as ready for review
July 24, 2019 02:50
Contributor
Author
|
Marking this as ready for review now, since I have migrated all of the class components I could find. |
There should be a check to see if messageInfo is defined first, before trying to access a property on it.
joshwooding
previously requested changes
Jul 24, 2019
joshwooding
left a comment
joshwooding
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, I haven’t marked all the things that should change but the main things I’ve spotted are changing withStyles to useStyles where possible and using the function variant of setting state.
eps1lon
reviewed
Jul 24, 2019
oliviertassinari
changed the title
oliviertassinari
approved these changes
Jul 25, 2019
I decided to remove the memoization entirely, as it might not be neccessary for this doc example.
Also improved the consistency of the Composition docs.
bpas247
commented
Jul 25, 2019
joshwooding
reviewed
Jul 27, 2019
joshwooding
reviewed
Jul 27, 2019
joshwooding
reviewed
Jul 27, 2019
joshwooding
reviewed
Jul 27, 2019
Co-Authored-By: Josh Wooding <[email protected]>
joshwooding
suggested changes
Jul 27, 2019
Co-Authored-By: Josh Wooding <[email protected]>
Simplify Dynamic CSS doc examples to use hooks for styling, and fix Consecutive Snackbars TS temo
Contributor
Author
|
Thanks a bunch for the reviews everyone 😃 this was a lot of fun to work on and I learned a few new things in the process 😎 |
merceyz
reviewed
Jul 28, 2019
joshwooding
reviewed
Jul 28, 2019
joshwooding
reviewed
Jul 28, 2019
joshwooding
reviewed
Jul 28, 2019
joshwooding
reviewed
Jul 28, 2019
joshwooding
reviewed
Jul 28, 2019
joshwooding
reviewed
Jul 28, 2019
joshwooding
approved these changes
Jul 29, 2019
Collaborator
|
@bpas247 Good Job 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My first pass-through of migrating all of the remaining class
component doc examples to function components via hooks.
Current list of class component doc examples that will need to be migrated:
Note: Please let me know if I'm missing any components here 😃
Since this is the last task on the issue:
closes #15231