@material-ui/lab: parsed: -1.60% 😍, gzip: -2.18% 😍

Generated by 🚫 dangerJS against a744d21

@joshwooding I can't seem to understand why the tests in SpeedDial are failing, can you kindly point me in the right direction as to what I am messing up.

@adeelibr I will have a quick look, see if I can help. @joshwooding is on holidays 🏖.

@adeelibr Ok, I have found the issue, it was the keydown event no correctly applied. The fix was:

@@ -272,7 +272,7 @@ describe.only('<SpeedDial />', () => {
      if (actionIndex === -1) {
        return getDialButton();
      }
-     return wrapper.find(SpeedDialAction).at(actionIndex);
+     return wrapper.find(SpeedDialAction).at(actionIndex).find(Fab);
    };

In general it's better to focus the element in question first and then apply a keydown to document.activeElement. That way you can test that the component in question is focusable and you prevent creating tests cases that will never happen in the browser.

Thank you for the help, I was stuck on this for 2 days. How silly of me. 😄

@adeelibr Could you rebase this with the latest master? We made some changes to the build pipeline that aren't included here yet. Those are required to pass.

@adeelibr Could you rebase this with the latest master? We made some changes to the build pipeline that aren't included here yet. Those are required to pass.

I am sorry for the late response, I have done a rebase =)

This commit had so much for me to learn 773ae51 Thank you @oliviertassinari 🎉

This commit was a bit off topic from the initial purpose of the pull request. The last time I have tried to remove keycode, I had the tests failing, and didn't want to spend the time looking at why. This time, we had an opportunity to batch the effort :).

@adeelibr Thank you