[Modal] Migrate to hooks#16254
Merged
Merged
Conversation
oliviertassinari
force-pushed
the
modal-hooks
branch
from
June 16, 2019 14:44
01c07a2 to
b3975a7
Compare
|
@material-ui/core: parsed: -0.33% 😍, gzip: -0.10% 😍 Details of bundle changes.Comparing: 75d9664...7941a32
|
joshwooding
reviewed
Jun 16, 2019
| and keeping it there until the modal is closed. | ||
| - ♿️ Adds the appropriate ARIA roles automatically. | ||
| - 📦 [6.5 kB gzipped](/size-snapshot). | ||
| - 📦 [5 kB gzipped](/size-snapshot). |
joshwooding
reviewed
Jun 16, 2019
joshwooding
left a comment
joshwooding
left a comment
Collaborator
There was a problem hiding this comment.
Modal changes look good, let's move the useTheme() changes out of this PR though :)
Member
Author
|
I propose the following split:
Would it work? This way we can differentiate the test changes from the refactorization? |
Collaborator
|
@oliviertassinari Perfect :) |
Member
Author
|
Done in #16262. |
1 task
oliviertassinari
force-pushed
the
modal-hooks
branch
from
June 18, 2019 22:07
ea6eedf to
7941a32
Compare
Member
Author
|
I have rebased on master. |
Member
Author
|
Next step will be #15839. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundle size of the Modal is going from 6,689 B to 5,100 B 😍🔥 (-23.47%)
Demo: https://deploy-preview-16254--material-ui.netlify.com/components/modal/.
Related to #15231