Skip to content

[SwipeableDrawer] Convert to function component#15947

Merged
eps1lon merged 5 commits into
mui:masterfrom
joshwooding:swipeabledrawer-function-component
Jun 10, 2019
Merged

[SwipeableDrawer] Convert to function component#15947
eps1lon merged 5 commits into
mui:masterfrom
joshwooding:swipeabledrawer-function-component

Conversation

@joshwooding

@joshwooding joshwooding commented May 29, 2019 •
edited by oliviertassinari
Loading

Copy link
Copy Markdown
Collaborator

A bonus: closes #15689.

@joshwooding joshwooding added type: new feature Expand the scope of the product to solve a new problem. component: SwipeableDrawer The React component. labels May 29, 2019
@joshwooding joshwooding mentioned this pull request May 29, 2019
Closed
29 tasks
@mui-pr-bot

mui-pr-bot commented May 29, 2019 •
edited
Loading

Copy link
Copy Markdown

@material-ui/core: parsed: -0.47% 😍, gzip: -0.22% 😍

Details of bundle changes.

Comparing: 2b98064...bd638ce

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.47% -0.22% 319,665 318,175 87,586 87,389
@material-ui/core/Paper 0.00% 0.00% 67,964 67,964 20,210 20,211
@material-ui/core/Paper.esm 0.00% -0.01% 61,258 61,258 19,019 19,017
@material-ui/core/Popper 0.00% -0.01% 28,966 28,966 10,416 10,415
@material-ui/core/Textarea 0.00% -0.13% 5,513 5,513 2,373 2,370
@material-ui/core/TrapFocus 0.00% +0.25% 🔺 3,755 3,755 1,577 1,581
@material-ui/core/styles/createMuiTheme 0.00% +0.02% 🔺 16,016 16,016 5,820 5,821
@material-ui/core/useMediaQuery 0.00% +0.09% 🔺 2,529 2,529 1,087 1,088
@material-ui/lab 0.00% +0.02% 🔺 138,600 138,600 42,601 42,609
@material-ui/styles 0.00% +0.01% 🔺 51,384 51,384 15,186 15,188
@material-ui/system 0.00% +0.02% 🔺 14,825 14,825 4,240 4,241
Button 0.00% +0.03% 🔺 83,893 83,893 25,495 25,502
Modal 0.00% -0.12% 20,343 20,343 6,690 6,682
colorManipulator 0.00% +0.06% 🔺 3,904 3,904 1,543 1,544
docs.landing 0.00% 0.00% 55,232 55,232 13,947 13,947
docs.main -0.24% -0.12% 653,982 652,429 206,779 206,526
packages/material-ui/build/umd/material-ui.production.min.js -0.50% -0.28% 293,117 291,639 83,504 83,273

Generated by 🚫 dangerJS against bd638ce

@joshwooding
joshwooding force-pushed the swipeabledrawer-function-component branch 5 times, most recently from c5da722 to 1f5e22b Compare May 29, 2019 21:52
@oliviertassinari

oliviertassinari commented May 29, 2019

Copy link
Copy Markdown
Member

Back in the game 💥

@joshwooding
joshwooding force-pushed the swipeabledrawer-function-component branch from 1f5e22b to e76f527 Compare May 29, 2019 22:01
@joshwooding

joshwooding commented May 29, 2019

Copy link
Copy Markdown
Collaborator Author

Of course Edge doesn’t like the change 🙄

@joshwooding
joshwooding force-pushed the swipeabledrawer-function-component branch 2 times, most recently from fd30189 to a53054e Compare June 2, 2019 13:58
@oliviertassinari oliviertassinari self-assigned this Jun 9, 2019
@oliviertassinari
oliviertassinari force-pushed the swipeabledrawer-function-component branch from 67b411c to 3e0ba65 Compare June 9, 2019 16:34
oliviertassinari
oliviertassinari reviewed Jun 9, 2019
View reviewed changes
Comment thread packages/material-ui/src/SwipeableDrawer/SwipeableDrawer.js Outdated
document.body.addEventListener('touchstart', handleBodyTouchStart);
document.body.addEventListener('touchmove', handleBodyTouchMove, { passive: false });
document.body.addEventListener('touchend', handleBodyTouchEnd);
// https://plus.google.com/+PaulIrish/posts/KTwfn1Y2238

@oliviertassinari oliviertassinari Jun 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google+ is out, an older version can be found at https://web.archive.org/web/20150608114000/https://plus.google.com/+PaulIrish/posts/KTwfn1Y2238. I believe we can ignore the problem. I haven't seen any recent resource about it. Watch https://www.youtube.com/watch?v=F3A6Skckh9c, no mention of the problem.

@oliviertassinari
oliviertassinari force-pushed the swipeabledrawer-function-component branch from 3e0ba65 to 88231c6 Compare June 9, 2019 17:43
@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. performance PR: good for merge and removed type: new feature Expand the scope of the product to solve a new problem. labels Jun 9, 2019
@oliviertassinari oliviertassinari removed their assignment Jun 9, 2019
@eps1lon

eps1lon commented Jun 10, 2019

Copy link
Copy Markdown
Member

Moved the cleanup next to the setup bd638ce.

Great job!

@eps1lon
eps1lon merged commit 06b4f34 into mui:master Jun 10, 2019
@joshwooding
joshwooding deleted the swipeabledrawer-function-component branch June 11, 2019 21:08
@oliviertassinari oliviertassinari added the scope: drawer Changes related to the drawer. label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

component: SwipeableDrawer The React component. performance scope: drawer Changes related to the drawer. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Swipeable drawer not working on ios

4 participants

@joshwooding @mui-pr-bot @oliviertassinari @eps1lon