Fix isBrowser detection#1568
Merged
shaurya947 merged 4 commits intomui:masterfrom Sep 29, 2015
izziaraffaele:fix/is-browser
Merged
Fix isBrowser detection#1568shaurya947 merged 4 commits intomui:masterfrom izziaraffaele:fix/is-browser
shaurya947 merged 4 commits intomui:masterfrom
izziaraffaele:fix/is-browser
Conversation
Member
|
Can we create a new utils file to prevent the duplication of the logic? |
Contributor
Author
|
There it is. You can close the issue I opened once you merge the PR |
src/left-nav.jsx
Outdated
Contributor
Author
|
Hey @oliviertassinari is there still something wrong? |
Member
|
I can't merge, @hai-cea can. Looks like he is on holidays :/ |
Contributor
|
Done! Thanks @izziaraffaele |
Contributor
Author
|
@shaurya947 I do what I can :) |
Contributor
Author
|
@shaurya947 Could you please update the npm version? Somehow in 0.12.1 I don't have this PR |
Contributor
|
@izziaraffaele might have to wait a couple more days before another 0.12.x release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking inspiration from https://github.com/akiran/can-use-dom I integrated a better way to handle environment detection.
It fixes an issue I opened yesterday #1551