Skip to content

[Popover] Convert to function component#15623

Merged
oliviertassinari merged 15 commits into
mui:masterfrom
joshwooding:popover-function-component
May 28, 2019
Merged

[Popover] Convert to function component#15623
oliviertassinari merged 15 commits into
mui:masterfrom
joshwooding:popover-function-component

Conversation

@joshwooding

@joshwooding joshwooding commented May 7, 2019

Copy link
Copy Markdown
Collaborator

@joshwooding joshwooding added type: new feature Expand the scope of the product to solve a new problem. component: Popover The React component. labels May 7, 2019
@joshwooding joshwooding mentioned this pull request May 7, 2019
Closed
29 tasks
@mui-pr-bot

mui-pr-bot commented May 7, 2019 •
edited
Loading

Copy link
Copy Markdown

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes.

Comparing: 5d9a3c8...ff70ea1

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +Infinity% 🔺 +Infinity% 🔺 0 314,590 0 86,295
@material-ui/core/Paper +Infinity% 🔺 +Infinity% 🔺 0 67,869 0 20,160
@material-ui/core/Paper.esm +Infinity% 🔺 +Infinity% 🔺 0 61,151 0 18,954
@material-ui/core/Popper +Infinity% 🔺 +Infinity% 🔺 0 28,740 0 10,351
@material-ui/core/Textarea +Infinity% 🔺 +Infinity% 🔺 0 5,513 0 2,382
@material-ui/core/TrapFocus +Infinity% 🔺 +Infinity% 🔺 0 3,744 0 1,581
@material-ui/core/styles/createMuiTheme +Infinity% 🔺 +Infinity% 🔺 0 15,960 0 5,782
@material-ui/core/useMediaQuery +Infinity% 🔺 +Infinity% 🔺 0 2,106 0 975
@material-ui/lab +Infinity% 🔺 +Infinity% 🔺 0 138,336 0 42,581
@material-ui/styles +Infinity% 🔺 +Infinity% 🔺 0 51,353 0 15,178
@material-ui/system +Infinity% 🔺 +Infinity% 🔺 0 14,458 0 4,177
Button +Infinity% 🔺 +Infinity% 🔺 0 84,060 0 25,573
Modal +Infinity% 🔺 +Infinity% 🔺 0 20,343 0 6,683
colorManipulator +Infinity% 🔺 +Infinity% 🔺 0 3,904 0 1,543
docs.landing +Infinity% 🔺 +Infinity% 🔺 0 47,836 0 10,920
docs.main +Infinity% 🔺 +Infinity% 🔺 0 653,367 0 205,545
packages/material-ui/build/umd/material-ui.production.min.js +Infinity% 🔺 +Infinity% 🔺 0 293,569 0 83,700

Generated by 🚫 dangerJS against ff70ea1

@joshwooding
joshwooding force-pushed the popover-function-component branch 2 times, most recently from 7b4531a to 5463d56 Compare May 12, 2019 14:46
@joshwooding

joshwooding commented May 14, 2019

Copy link
Copy Markdown
Collaborator Author

Hopefully, they all pass now (they pass locally). I still need to do a bit of tidying though.

@joshwooding
joshwooding force-pushed the popover-function-component branch 11 times, most recently from c01e367 to 7f2a3d9 Compare May 16, 2019 22:59
@joshwooding
joshwooding force-pushed the popover-function-component branch from 7f2a3d9 to ee51588 Compare May 19, 2019 13:00
@joshwooding
joshwooding force-pushed the popover-function-component branch 6 times, most recently from a7d99e5 to 67c2445 Compare May 19, 2019 21:46
@joshwooding
joshwooding force-pushed the popover-function-component branch from 8f8c176 to 902fd8f Compare May 19, 2019 22:12
@joshwooding
joshwooding marked this pull request as ready for review May 19, 2019 22:41
eps1lon
eps1lon reviewed May 20, 2019
View reviewed changes
Comment thread packages/material-ui/src/Popover/Popover.test.js Outdated
@joshwooding
joshwooding requested a review from eps1lon May 20, 2019 22:26
@oliviertassinari
oliviertassinari changed the base branch from next to master May 23, 2019 21:08
@oliviertassinari
oliviertassinari merged commit bcca9eb into mui:master May 28, 2019
@oliviertassinari

oliviertassinari commented May 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Great job!

@joshwooding
joshwooding deleted the popover-function-component branch May 28, 2019 09:09
@mmk0083 mmk0083 mentioned this pull request Jun 12, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes
@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees

No one assigned

Labels

component: Popover The React component. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshwooding @mui-pr-bot @oliviertassinari @eps1lon