[EnhancedTextarea] add rowsMax property#1562
Merged
shaurya947 merged 1 commit intomui:masterfrom Sep 29, 2015
oliviertassinari:textarea
Merged
[EnhancedTextarea] add rowsMax property#1562shaurya947 merged 1 commit intomui:masterfrom oliviertassinari:textarea
shaurya947 merged 1 commit intomui:masterfrom
oliviertassinari:textarea
Conversation
Contributor
There was a problem hiding this comment.
I see that you made the styles global.
Do you think in the future we could use some styles from the theme for this component? That would cause issues with this global approach right? Nearly all components implement a getStyles() method. I think we should be consistent about that. What do you think @oliviertassinari?
Member
Author
There was a problem hiding this comment.
I'm using a global styles for performance reasons.
Member
There was a problem hiding this comment.
@shaurya947 @oliviertassinari I think declaring the constant in this way is fine here. Since the styles object doesn't depend on the instance of the component, declaring the constant outside is a little more efficient.
shaurya947
added a commit
that referenced
this pull request
Sep 29, 2015
[EnhancedTextarea] add rowsMax property
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.16.0 to 7.19.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.16.0...v7.19.0) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zannager
added
scope: text field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.