[ListItem] remove useless margin: 0#1542
[ListItem] remove useless margin: 0#1542shaurya947 merged 1 commit intomui:masterfrom oliviertassinari:patch-5
Conversation
src/lists/list-item.jsx
Outdated
There was a problem hiding this comment.
@oliviertassinari for consistency, and for future readability and maintainability, I would rather just change this line to:
primaryText: {},Thoughts?
There was a problem hiding this comment.
this was my original PR, then I just though, the less dead code there is, the best it's.
There was a problem hiding this comment.
I feel that in the future if we do decide to add some styling for the primaryText, leaving it like that would make it easier to locate, and it also feels more consistent with all the other style key:value pairs.
It's up to you though. Let me know what you decide. :-)
There was a problem hiding this comment.
Well, as you want. Regarding this component, I thinks that we should make it composable in the futur.
There was a problem hiding this comment.
Cool, let me know when I merge this!
|
@shaurya947 Done |
[ListItem] remove useless margin: 0
|
Thanks @oliviertassinari |
3 participants
No description provided.