Skip to content

[Textarea] Refactor the implementation#15331

Merged
oliviertassinari merged 5 commits into
mui:nextfrom
oliviertassinari:Textarea
Apr 15, 2019
Merged

[Textarea] Refactor the implementation#15331
oliviertassinari merged 5 commits into
mui:nextfrom
oliviertassinari:Textarea

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Apr 12, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

I think that we should make this component public in v4+.

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. scope: text field Changes related to the text field. labels Apr 12, 2019
@mui-pr-bot

mui-pr-bot commented Apr 12, 2019 •
edited
Loading

Copy link
Copy Markdown

@material-ui/core: parsed: -0.36% 😍, gzip: +0.10%

Details of bundle changes.

Comparing: 6891704...415ec90

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.36% +0.10% 🔺 317,543 316,385 85,413 85,502
@material-ui/core/Paper 0.00% +0.12% 🔺 67,276 67,277 19,952 19,975
@material-ui/core/Paper.esm 0.00% -0.04% 60,639 60,639 18,891 18,883
@material-ui/core/Popper 0.00% -0.03% 34,906 34,906 11,864 11,861
@material-ui/core/Textarea +Infinity% 🔺 +Infinity% 🔺 0 5,866 0 2,465
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,898 15,898 5,773 5,773
@material-ui/core/useMediaQuery -14.49% -6.26% 2,463 2,106 1,039 974
@material-ui/lab -0.00% -0.01% 144,208 144,207 43,542 43,539
@material-ui/styles 0.00% +0.05% 🔺 50,831 50,831 15,012 15,020
@material-ui/system 0.00% +0.15% 🔺 11,765 11,765 3,923 3,929
Button 0.00% +0.02% 🔺 88,247 88,247 26,495 26,501
Modal -0.02% -0.04% 82,539 82,524 24,831 24,821
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 50,908 50,908 11,210 11,210
docs.main -0.23% -0.12% 648,953 647,485 202,251 202,008
packages/material-ui/build/umd/material-ui.production.min.js -0.42% -0.10% 294,201 292,961 82,555 82,472

Generated by 🚫 dangerJS against 415ec90

@oliviertassinari
oliviertassinari force-pushed the Textarea branch 2 times, most recently from a696dad to dcf6ca2 Compare April 12, 2019 23:15
@oliviertassinari
oliviertassinari marked this pull request as ready for review April 12, 2019 23:24
@oliviertassinari
oliviertassinari force-pushed the Textarea branch 4 times, most recently from 79e0c83 to 4d09a2e Compare April 13, 2019 09:38
eps1lon
eps1lon previously requested changes Apr 13, 2019
View reviewed changes
Comment thread packages/material-ui/src/ButtonBase/ButtonBase.js
joshwooding
joshwooding reviewed Apr 14, 2019
View reviewed changes
Comment thread packages/material-ui/src/InputBase/Textarea.js
@joshwooding joshwooding mentioned this pull request Apr 14, 2019
Closed
29 tasks
eps1lon
eps1lon reviewed Apr 14, 2019
View reviewed changes
Comment thread packages/material-ui/src/InputBase/Textarea.js Outdated
Comment thread packages/material-ui/src/InputBase/Textarea.js
Comment thread packages/material-ui/src/InputBase/Textarea.js Outdated
Comment thread packages/material-ui/src/InputBase/Textarea.js Outdated
Comment thread packages/material-ui/src/InputBase/Textarea.test.js Outdated
Comment thread packages/material-ui/src/InputBase/Textarea.test.js Outdated
Comment thread packages/material-ui/src/InputBase/Textarea.test.js Outdated
Comment thread packages/material-ui/src/InputBase/Textarea.test.js Outdated
Comment thread packages/material-ui/src/InputBase/Textarea.test.js Outdated
@oliviertassinari

oliviertassinari commented Apr 14, 2019

Copy link
Copy Markdown
Member Author

Thanks for the reviews, I have tried to take them all into account.

@oliviertassinari

oliviertassinari commented Apr 14, 2019

Copy link
Copy Markdown
Member Author

I have tried to replace the 2 textareas with a single one. It seems to work perfectly 👌💎.

@oliviertassinari oliviertassinari self-assigned this Apr 14, 2019
@oliviertassinari oliviertassinari removed their assignment Apr 14, 2019
@oliviertassinari
[Textarea] Refactor the implementation
5bb2a81
@oliviertassinari
reduce bundle size
0449482 
Before:

@material-ui/core: parsed: -0.34% 😍, gzip: -0.20% 😍
@material-ui/core/Textarea	+Infinity% 🔺	+Infinity% 🔺	0	6,750	0	2,669
@oliviertassinari
Revert "reduce bundle size"
7a949e0 
This reverts commit 4d09a2e.
@oliviertassinari
Sebastian review
ec7ddb1
@oliviertassinari
one textarea, smaller
415ec90
@oliviertassinari
oliviertassinari merged commit 71d4ebe into mui:next Apr 15, 2019
@oliviertassinari
oliviertassinari deleted the Textarea branch April 15, 2019 10:15
@oliviertassinari oliviertassinari mentioned this pull request Apr 19, 2019
Closed
2 tasks
@epicfaace epicfaace mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon left review comments
+1 more reviewer
@joshwooding joshwooding joshwooding left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

scope: text field Changes related to the text field. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

4 participants

@oliviertassinari @mui-pr-bot @eps1lon @joshwooding