[Tooltip] Suppress disabled button warning when controlled#15304
Merged
oliviertassinari merged 3 commits intoApr 11, 2019
Merged
[Tooltip] Suppress disabled button warning when controlled#15304oliviertassinari merged 3 commits into
oliviertassinari merged 3 commits into
Conversation
oliviertassinari
added
scope: tooltip
oliviertassinari
changed the title
Member
|
@tasinet This sounds like a great thank! Thank you. For the context, @joshwooding is refactoring the component in #15291. |
|
No bundle size changes comparing 3b084f6...b889b95 |
oliviertassinari
approved these changes
Apr 10, 2019
joshwooding
approved these changes
Apr 10, 2019
Member
|
@tasinet Thank you for working on it! |
1 task
Contributor
Author
|
My pleasure :) Thanks for the speedy merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This suppresses the warning as described in #15303. Includes unit test.
Also: wording fix in existing test title - should probably be "can not" listen to events
Closes #15303.