Skip to content

[ci] Don't use -browser images#14779

Merged
eps1lon merged 2 commits into
mui:nextfrom
eps1lon:ci/use-vanilla-image
Mar 7, 2019
Merged

[ci] Don't use -browser images#14779
eps1lon merged 2 commits into
mui:nextfrom
eps1lon:ci/use-vanilla-image

Conversation

@eps1lon

@eps1lon eps1lon commented Mar 7, 2019

Copy link
Copy Markdown
Member

Partial revert of #14643.

While the build with -browser images technically improved reproducability of the build it creates less deterministic builds. The selenium image even caused errors on builds with the exact same docker images sha.

Prerequisite for #14775

@eps1lon eps1lon added type: bug It doesn't behave as expected. test labels Mar 7, 2019
@mui-pr-bot

mui-pr-bot commented Mar 7, 2019

Copy link
Copy Markdown

No bundle size changes comparing 7c3a016...8f60a6f

Generated by 🚫 dangerJS against 8f60a6f

@eps1lon
eps1lon merged commit b8a3336 into mui:next Mar 7, 2019
@eps1lon
eps1lon deleted the ci/use-vanilla-image branch March 7, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants