[Modal] Forward refs#14738
Merged
Merged
Conversation
eps1lon
added
breaking change
eps1lon
commented
Mar 4, 2019
| * This component shares many concepts with [react-overlays](https://react-bootstrap.github.io/react-overlays/#modals). | ||
| */ | ||
| class Modal extends React.Component { | ||
| mounted = false; |
Member
Author
There was a problem hiding this comment.
This was never read. Only written to.
Details of bundle changes.Comparing: bcb4bec...b4387d9
|
oliviertassinari
approved these changes
Mar 4, 2019
Tossed some out that had no meaningful assertion in it or insufficient description of what the test is supposed to do
eps1lon
force-pushed
the
feat/Modal/forwardRef
branch
from
March 5, 2019 08:01
77cd916 to
b4387d9
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #14536