Skip to content

[core] Replace hoistMuiStatics usages#14722

Merged
eps1lon merged 1 commit into
mui:nextfrom
oliviertassinari:remove-hoistMuiStatics
Mar 4, 2019
Merged

[core] Replace hoistMuiStatics usages#14722
eps1lon merged 1 commit into
mui:nextfrom
oliviertassinari:remove-hoistMuiStatics

Conversation

@oliviertassinari

@oliviertassinari oliviertassinari commented Mar 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

The whole community is using hoist-non-react-statics, let's go for it. We should be able to remove the yarn version lock at some point.

This change is taken from #14560 as an effort not to merge too big pull requests.

@oliviertassinari
oliviertassinari requested a review from eps1lon March 3, 2019 11:41
@mui-pr-bot

mui-pr-bot commented Mar 3, 2019 •
edited
Loading

Copy link
Copy Markdown

@material-ui/lab: parsed: -0.16% 😍, gzip: -0.26% 😍

Details of bundle changes.

Comparing: 54c1d80...7c5174a

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.06% -0.07% 371,600 371,376 91,877 91,811
@material-ui/core/Paper -0.37% -0.37% 76,930 76,649 19,372 19,301
@material-ui/core/Paper.esm -0.00% +0.02% 🔺 71,601 71,599 18,779 18,782
@material-ui/core/Popper 0.00% +0.01% 🔺 30,462 30,462 10,582 10,583
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,286 17,286 5,717 5,717
@material-ui/core/useMediaQuery 0.00% -0.10% 2,486 2,486 1,048 1,047
@material-ui/lab -0.16% -0.26% 184,505 184,216 50,732 50,598
@material-ui/styles -0.48% -0.60% 57,720 57,443 16,273 16,176
@material-ui/system 0.00% -0.04% 17,062 17,062 4,487 4,485
Button -0.22% -0.11% 99,633 99,409 26,634 26,604
Modal -0.00% +0.05% 🔺 98,713 98,711 26,171 26,183
colorManipulator 0.00% 0.00% 3,232 3,232 1,296 1,296
docs.landing 0.00% 0.00% 51,773 51,773 11,244 11,244
docs.main -0.05% -0.04% 678,825 678,482 206,233 206,150
packages/material-ui/build/umd/material-ui.production.min.js -0.05% -0.05% 322,256 322,106 85,048 85,004

Generated by 🚫 dangerJS against 7c5174a

@oliviertassinari
oliviertassinari force-pushed the remove-hoistMuiStatics branch from 5b3d07f to 7c5174a Compare March 3, 2019 11:49
eps1lon
eps1lon approved these changes Mar 4, 2019
View reviewed changes

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. It's not the best solution but follows the principle of least surprise.

@eps1lon
eps1lon merged commit 129daff into mui:next Mar 4, 2019
@oliviertassinari
oliviertassinari deleted the remove-hoistMuiStatics branch March 4, 2019 07:56
@oliviertassinari oliviertassinari mentioned this pull request Mar 8, 2019
Closed
2 tasks
@henkvhest henkvhest mentioned this pull request Mar 11, 2019
Closed
2 tasks
@zannager zannager added the internal Behind-the-scenes enhancement. Formerly called “core”. label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes
+1 more reviewer
@joshwooding joshwooding joshwooding approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oliviertassinari @mui-pr-bot @eps1lon @joshwooding @zannager