[ci] Speedup and cleanup#14643
Merged
Merged
Conversation
|
No bundle size changes comparing bfa9167...bcd0a30 |
Network problems should be resolved
- moves docs/ related tasks together - reduces build time for test_browser which is currently the bottleneck to test_regressions
Skaronator
suggested changes
Feb 23, 2019
Co-Authored-By: eps1lon <[email protected]>
| - run: | ||
| name: Are the compiled TypeScript demos equivalent to the JavaScript demos? | ||
| command: git diff --exit-code | ||
| - run: |
Member
There was a problem hiding this comment.
👍 for the better load balance
It'll be invalidated on every run anyway since it looks at mtime and that changes with every checkout
oliviertassinari
approved these changes
Feb 24, 2019
| working_directory: /tmp/material-ui | ||
| docker: | ||
| - image: circleci/node:8.15 | ||
| - image: circleci/node:8.15-browsers |
Member
There was a problem hiding this comment.
What do you think of reverting this change? The tests relying on Chrome Headless are flaky now:
- Tests real browsers https://circleci.com/gh/mui-org/material-ui/75600?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
- Test umd release https://circleci.com/gh/mui-org/material-ui/75614?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
cc @joshwooding
New failures
Member
Author
There was a problem hiding this comment.
Tests are flaky on 8.15 too: https://circleci.com/gh/mui-org/material-ui/76445. Need to pin to exact versions it seems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General effort to remove some complexity from
.circleci/config.ymland speedup build times. Commits are atomic.Changes: